geosolutions-it / MapStore2 / 29265623079

76%

master: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix #12620 cyclomedia orb issue (#12631) (#12638)

* Fix #12620 Cyclomedia images not shown

Cyclomedia retired the v23.7 StreetSmart API endpoint hardcoded as
default; their server now falls back to serving their own web app
shell (HTML) instead of a 404, which Chrome blocks as an opaque
response (ERR_BLOCKED_BY_ORB) when loaded as a script. Bump default
to the current v26.1, confirmed live and API-compatible.

Restrict providerSettings.StreetSmartApiURL to cyclomedia.com hosts,
consistent with the other cyclomedia endpoints already used by this
provider, falling back to the default otherwise.

* Show an error when the StreetSmart API fails to load

Previously, if the iframe's script tag failed to load or execute
(network issue, wrong/dead API version, blocked request), the plugin
was left stuck on the "Loading Street Smart API..." spinner forever
with no feedback. Detect this on iframe load and surface a proper
error message instead.

Also fixes a regression from the StreetSmartApiURL host validation:
an explicit empty string (used by tests to inject a mocked API via
`scripts` instead of loading a real script) was being treated as
invalid and replaced with the default URL.

(cherry picked from commit c27c111c7)

Coverage Stats

35719 of 56454 branches covered (63.27%)

9 of 17 new or added lines in 1 file covered. (52.94%)

2 existing lines in 2 files now uncovered.

44498 of 58854 relevant lines covered (75.61%)

122.15 hits per line