jhheider / pdcst / 29265588594

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix: background refresh no longer erases resume position, downloads, and now-playing (#32)

The real cause of "quit mid-play loses the position / now-playing / has to
rebuffer" was not the save path - it was the refresh path. `insert_episode`
was an `INSERT OR REPLACE`, and the refresher re-inserts every parsed
episode on each (hourly + on-launch) refresh. For an episode that already
exists, REPLACE deletes the row and inserts a new one:

- user-state columns (playback_position_seconds, played, download_status,
  local_path) are reset to the parsed feed's defaults - wiping the resume
  point and making downloaded episodes look un-downloaded (re-stream), and
- `Episode::new` mints a fresh id each parse, so the delete trips the
  playback_state `ON DELETE SET NULL` and the queue FKs - nulling the
  now-playing episode and dropping queued items.

Ground truth from the live DB confirmed it: 6604 episodes, zero with a
nonzero position, and playback_state.current_episode_id NULL with a live
position. Fix: make `insert_episode` a metadata-only upsert
(`ON CONFLICT(subscription_id, guid) DO UPDATE SET <feed fields>`) that
never deletes and never touches user-state; downloads/position/played are
persisted by their own dedicated UPDATEs.

Also, per the ask, throttle the position checkpoint to
`save_position_interval_seconds` (default 10, previously unused) instead of
every 1s tick - pause/stop/quit still save immediately, so this only bounds
the crash-loss window while cutting DB churn ~10x.

Test: refresh_reinsert_preserves_user_state_and_identity asserts a
same-guid/fresh-id re-insert keeps the id, position, played, download, and
the now-playing FK, while refreshing feed metadata. Would fail under the
old REPLACE.


Claude-Session: https://claude.ai/code/session_014meUZPwNWx1cfEub4Ncx3Y

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

10 of 24 new or added lines in 4 files covered. (41.67%)

419 existing lines in 11 files now uncovered.

3826 of 5756 relevant lines covered (66.47%)

2618928.43 hits per line