pantsbuild / pants / 29261418526

Build # 29261418526

Build Type

push

github

Committed by web-flow

Commit Message

split invalidate_randomly into two deterministic tests (#23280)

This test was identified as flaky in 2020 and went through a prior
re-enable/backout dance. On my workstation with no load I can run it
1000 times without error. Under artificial cpu load (nice + dummy procs)
it fails ~20% of the time. So I think this is a straightforward timing
based assertion problem.

To "fix" this, the test is broken out into two smaller tests:
 * An assertion on small deterministic inputs.
 * Liveness under random invalidation.

I think the ideal fix would be some sort of fuzz or property based
testing system. But since once hasn't been adopted already and this test
has hung out for six years, I think this is a positive incremental move
forward.

closes #10839

Notice: A LLM both did the "run the tests a bunch scripting" and
generated the final code. I made the call on splitting versus futzing
with timeouts or high scope logical clock changes.

Coverage Stats

76293 of 87649 relevant lines covered (87.04%)

3.06 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available