dangernoodle-io / breadboard / 29262512562

95%

push

github

refactor: reimplement bb_release_manifest github parsers on bb_serialize_json scanner (#847)

- both the streaming (bb_release_manifest_github_stream.c) and buffered
  (bb_release_manifest_github.c) GitHub release-manifest parsers now drive
  the shared bb_serialize_json_ingest_t sink (bb_release_manifest_json_sink.c/.h)
  over bb_serialize_json_scan_begin/_feed/_end and bb_serialize_json_scan_bounded,
  retiring both bespoke hand-rolled JSON scanners
- early-stop: once tag_name and the matching asset URL are both found, the
  sink returns a private sentinel that aborts the scan; both parsers mask it
  back to BB_OK before it ever reaches a caller
- streaming _feed() masks a mid-stream grammar error to BB_OK (matching the
  old lenient parser's contract exactly -- only a real buffer overflow
  aborts the transport); _end() still folds a malformed body into
  BB_ERR_NOT_FOUND via bb_release_manifest_sink_finalize()
- BB_RELEASE_MANIFEST_STREAM_STATE_SIZE grows 512 -> 768 bytes to hold the
  embedded bb_serialize_json scanner state (disclosed, not silent)
- two disclosed behavior harmonizations where the old buffered and
  streaming parsers had diverged (matching asset missing its url; a
  non-array "assets" value): both now fold to the streaming parser's
  BB_OK-with-empty-url terminal, since they now share one sink

4454 of 4454 branches covered (100.0%)

Branch coverage included in aggregate %.

135 of 135 new or added lines in 3 files covered. (100.0%)

7047 of 7047 relevant lines covered (100.0%)

8565.34 hits per line