zalando / skipper / 29261422568

push

github

fix(proxy): isolate and apply 30s timeout to upgrade proxy dialer (#4125)

This Pull Request resolves a critical P0 availability defect regarding
unbounded goroutine accumulation within the WebSocket and HTTP upgrade
proxy pathways under stalled backend conditions.

By replacing the blocking, context-less net.Dial and tls.Dial calls
inside dialBackend() with context-aware DialContext routines, the proxy
now correctly propagates req.Context() cancellation and enforces a
strict dial timeout.

The timeout has been fully wired into the proxy configuration factory,
defaulting to 30 seconds while allowing direct overrides via
Params.Timeout. Comprehensive regression and E2E timeout verification
tests have been integrated into proxy/upgrade_test.go.

---------

Signed-off-by: glatinone <93207632+glatinone@users.noreply.github.com>

19 of 23 new or added lines in 4 files covered. (82.61%)

28864 of 35899 relevant lines covered (80.4%)

84644.35 hits per line