dangernoodle-io / breadboard / 29225648869

95%

push

github

refactor: delete unreachable wifi recovery code (bb_wifi_init, force_reassociate, boot-count threshold) (#844)

- delete bb_wifi_init() (esp-idf/r4/cc3000) and its zero-caller
  restart_on_timeout=true path; also delete the now-unreachable
  cold-timeout reboot + boot_count-increment branch in
  wifi_connect_sta_ex(), collapsing restart_on_timeout and the
  never-read is_pending_try param out of the function signature
- delete bb_wifi_force_reassociate() (esp-idf/r4/cc3000), zero callers.
  TA-440 ("wire force_reassociate for zombie-connected recovery") is
  being closed as won't-do alongside this: the wifi FSM lane handles
  the zombie case via an ST_ASSOCIATED state + DHCP timeout, not a
  manual reassociate kick
- delete bb_system_boot_count_get() + BB_SYSTEM_BOOT_FAIL_THRESHOLD
  (host/esp-idf/arduino) -- written via _increment()/_reset() but never
  read outside of _increment()'s own internal use and host tests; the
  threshold was never compared against anything. Deliberately kept
  _increment()/_reset() (cheap bookkeeping the wifi FSM work may adopt)
- remove the dead ST_BACKOFF write on the RECONNECT_NOW disconnect path
  in wifi_reconn.c -- the caller unconditionally overrides it to
  ST_CONNECTING when backoff_ms==0, so the assignment was never observed

PR0 of the B1-790 WiFi FSM lane. Pure deletion, no behavior change.


Claude-Session: https://claude.ai/code/session_01WcT1TPAV2UE4VeGuDL7K8p

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

4075 of 4075 branches covered (100.0%)

Branch coverage included in aggregate %.

6611 of 6611 relevant lines covered (100.0%)

7886.07 hits per line