dangernoodle-io / breadboard / 29222209404

95%

push

github

refactor: move NVS partition bring-up from bb_nv to bb_storage_nvs (#842)

- add bb_storage_nvs_flash_init()/bb_storage_nvs_flash_was_erased(),
  moving the nvs_flash_init() erase-and-retry sequence verbatim from
  bb_nv_flash_init() (B1-840, bb_nv dissolution epic B1-708)
- guard the sequence with bb_once so it runs exactly once regardless
  of caller count (bb_storage_nvs_register()'s internal call + bb_nv's
  internal call)
- fold flash_init() into bb_storage_nvs_register() itself (the ONE
  composition-root call, propagating any error) instead of graph-
  ordering two separate calls -- a downstream composer wiring
  esp_wifi_init() ahead of NVS bring-up is now structurally
  impossible, not merely detected by a graph edge; the // bbtool:init
  tier=early marker lives only on bb_storage_nvs_register()
- bb_nv_flash_init()/bb_nv_config_was_erased() remain thin forwarders
- add a host test proving the bb_once guard around flash_init's body
  runs exactly once across repeated calls (via a host-only injection
  seam, since the real erase-and-retry body is device-only)

Note: the erase log message's TAG now binds to "bb_storage_nvs"
instead of "nv_config" (bb_nv.c has two file tags: TAG_NV="bb_nv" and
TAG="nv_config") -- a fleet log-scraper keying on TAG rather than
message text should account for this.

4075 of 4075 branches covered (100.0%)

Branch coverage included in aggregate %.

6611 of 6611 relevant lines covered (100.0%)

7900.72 hits per line