boardgameio / boardgame.io / 29202051937

100%

master: 100%

push

github

fix(client): stop subscriber ID collisions after unsubscribe (#1259)

* fix(client): stop subscriber ID collisions after unsubscribe

Client.subscribe derived new subscriber IDs from the current subscriber
count. After any subscriber other than the most recent one
unsubscribed, the count pointed at an ID that was still live, so the
next subscribe silently overwrote an existing subscriber, which then
stopped receiving state updates.

Mint IDs from a monotonic per-client counter instead, so an ID is
never reused. Adds a regression test reproducing the exact scenario
from the report.

Fixes #1137

* refactor(client): use symbols for subscriber IDs

1995 of 1995 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

2873 of 2873 relevant lines covered (100.0%)

26706.75 hits per line