sunng87 / handlebars-rust / 29182080848

84%

push

github

fix: handle leading tilde on `else if` chain tags (#768)

`{{~else if cond}}` panicked during template compilation with
`unreachable: leading_tilde_to_omit_whitespace`.

The grammar places the optional leading tilde of `invert_chain_tag`
before `invert_tag_item`, but the compile code called `parse_name`
(before `parse_expression`) to consume `invert_tag_item`, so the
leading tilde was handed to `parse_name` and hit its `unreachable!`
arm. The plain `{{~else}}` (`invert_tag`) case already worked because
it skips `parse_name` and `parse_expression` handles the tilde itself.

Consume the optional leading tilde before `parse_name` for
`invert_chain_tag`, and fold its `omit_pre_ws` semantics into the
parsed expression so preceding whitespace is stripped consistently
with `{{~else}}`.

Fixes #766.

7 of 7 new or added lines in 1 file covered. (100.0%)

1707 of 2007 relevant lines covered (85.05%)

8.05 hits per line