winstonjs / winston / 29180866087

71%

push

github

Fix race condition causing hang in lazy file transport rotation (#2627)

* Initial plan

* Fix race condition in lazy file transport rotation path

When using `lazy: true` with `maxsize`, a race condition could cause
`logToTransport` to hang forever:

1. After a file fills up, `_endStream` closes and destroys `_dest`
2. The next `log()` call detects `_needsNewFile()` is true and attaches
   a `_dest.once('close', ...)` listener to trigger file rotation
3. If `_dest` was already destroyed before the listener is attached,
   the 'close' event is never received and the write callback is
   never invoked — causing the promise to hang until the Jest timeout

Fix: check `_dest.destroyed` before registering the 'close' listener.
If the stream is already destroyed, invoke `open()` immediately rather
than waiting for an event that will never arrive.

* Restore explicit return in openNextFile callback for style consistency

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

444 of 681 branches covered (65.2%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

786 of 1056 relevant lines covered (74.43%)

1110.57 hits per line