dal-go / dalgo / 29173543370

100%

push

github

dalgo2memory: key nested records by full path to fix cross-parent collision (#90)

Records live in a per-leaf-collection storage engine keyed by keyID, which
was the bare leaf id. Two records sharing a leaf id under different parents
(spaces/A/items/i1 and spaces/B/items/i1) therefore collided: the second Set
silently overwrote the first, unlike Firestore where they are distinct docs.

Fix:
- keyID keys nested records by their full parent-chain path (root-level
  records keep the bare leaf id, so existing behavior and the white-box
  engine tests are unchanged). Uses a panic-safe keyPath rather than
  dal.Key.String, which validates and panics on incomplete keys.
- columnarEngine.compact now rebuilds slotToKey alongside slotToID; without
  it a collection-group query lost each surviving record's parent after a
  compaction re-indexed slots.

Tests (fail without the fix, pass with it) cover the serialized and columnar
engines, deletion isolation, and parent-key survival across compaction.
Package coverage stays at 100%.


Claude-Session: https://claude.ai/code/session_01RU2Ve3AvUPrGwQxebsdD2C

Co-authored-by: Alexander Trakhimenok <trakhimenok@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

16 of 16 new or added lines in 2 files covered. (100.0%)

7493 of 7493 relevant lines covered (100.0%)

1.15 hits per line