bleachbit / bleachbit / 29164250500

77%

push

github

Merge pull request #2186 from XhmikosR/xmr/imrove-mozilla-favicons

Improve Mozilla favicons

The argument to `lstrip()` should be a list of characters, while the old
code here was treating it like a string to remove. It was used for comparisons
and mangled both sides equally.

After calling `execute_sqlite3()`, the old code appended more commands to
the variable  `cmd` without resetting its value, so commands were repeated.
This was functionally harmless, but now resetting `cmd` avoids unneeded
work.

If `ids_to_delete` were empty, then the empty `in ( )` syntax would cause
SQLite to emit an error.

This PR did not aim to address issue #1537 (bookmark icons deleted), but for
clarity, these changes in this PR are not expected to fix #1537.

10 of 10 new or added lines in 1 file covered. (100.0%)

8097 of 10617 relevant lines covered (76.26%)

0.76 hits per line