dangernoodle-io / breadboard / 29163525742

95%

push

github

feat: migrate hostname to bb_settings (#817)

- adds bb_settings_hostname_get/set (B1-754, part of B1-708 bb_nv dissolution);
  validation logic moved verbatim from bb_nv's nv_valid_hostname (RFC 1123
  charset/length/hyphen rules)
- byte-compat preserved: same NVS namespace ("bb_cfg") and key ("hostname")
  bb_nv used, so provisioned boards keep their stored hostname; unset
  resolves to bb_config's has_default="" (no MAC-derived default), matching
  bb_nv's prior empty-string-on-unset behavior exactly
- swaps every real consumer (bb_wifi, bb_mqtt_client, bb_telemetry_routes,
  bb_pub, bb_sink_http) from bb_nv_config_hostname()/set_hostname() to the
  new bb_settings accessors; deletes the hostname field, validator, and
  both get/set functions from bb_nv (host + espidf branches)
- adds a shared host-test seed helper (test_hostname_seed.c/.h) so the ~13
  test files that seed a hostname for bb_pub/sink assertions can do so via
  the real bb_settings_hostname_set() API without wiring up NVS
- moves the 7 hostname unit tests from test_nv_config.c to test_bb_settings.c
  and adds set-validation coverage (null/empty/too-long/hyphen/charset)
- manifest callout: bb_nv's s_bb_cfg_keys[] no longer carries a hostname
  entry, so it drops out of /api/manifest -- there is no breadboard HTTP
  writer for it today, consistent with the bb_manifest dissolution direction
- fixes hostname field's max_len to 33 (buffer capacity, not usable-char
  count) so a valid 32-char hostname round-trips instead of being rejected;
  adds a 32-char boundary regression test
- caches the resolved hostname once in bb_pub's own state and reuses it
  per tick, restoring the old O(1)-per-tick read (hostname is a
  reboot_required bb_settings field, so it cannot change without a reboot)


Claude-Session: https://claude.ai/code/session_01VQXiyqFjcMpPPpef5TL9gA

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

3319 of 3319 branches covered (100.0%)

Branch coverage included in aggregate %.

5268 of 5268 relevant lines covered (100.0%)

9944.47 hits per line