HEROgold / confkit / 29158375931

98%

Build Type

push

github

Committed by web-flow

Commit Message

Fix red CI on master: type checks and failing tests (#70)

* Fix red CI on master: type checks and failing tests

- data_types: handle cast(None) via NoneType so BaseDataType.cast is total;
  base Binary on BaseDataType[int] (bytes are converted to int on input) so
  binary config values type as int and drop the mypy str-bytes-safe warning.
- config: type on_file_change's `old` param as VT (drop the invalid VT | UNSET
  sentinel); silence the invariant BaseDataType[VT | None] assignment on the
  optional path for pyrefly.
- ext/parsers: implement MsgspecParser.set_option and return the fallback
  directly from get, resolving the abstract-class instantiation error.
- examples: ignore method-assign on the per-instance on_file_change assignment
  and give the callbacks concrete parameter types.
- tests: noqa PTH201 on the deliberate current-dir path assertions; mark the
  ConfigTest.on_file_change override with @override.

* Import override from typing_extensions for 3.10/3.11 support

typing.override was added in 3.12; CI tests 3.10-3.14, so importing it from
typing broke collection of test_on_file_change.py on 3.10/3.11.

Coverage Stats

11 of 12 new or added lines in 5 files covered. (91.67%)

19 existing lines in 2 files now uncovered.

2722 of 2772 relevant lines covered (98.2%)

0.98 hits per line