kevinoid / node-project-template / 29148752952

96%

push

github

fix(editorconfig): don't trim diff whitespace

The [Unified Diff Format] will contain trailing whitespace in at least
four cases:

1. If a line being removed contained trailing whitespace.
2. If a line being added contained trailing whitespace.
3. If a line common to both files (context line) contained trailing
   whitespace.
4. If an empty line was common to both files (causing the prefix space
   to be trailing whitespace).

Removing the trailing whitespace will either break the diff or cause a
change in semantics:

1. The patch will fail to match the removed line.
2. The patch will add a different line than it did before.
3. The patch will fail to match the common lines.
4. The patch may be considered invalid or fail to match.

Although #2 may be desired in some cases, the others are certainly not.
Therefore, do not remove trailing whitespace when editing a patch in a
text editor (e.g. editing a hunk from `git add -p`).

[Unified Diff Format]: https://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

33 of 38 branches covered (86.84%)

Branch coverage included in aggregate %.

160 of 164 relevant lines covered (97.56%)

18.44 hits per line