ben-manes / caffeine / #5609

100%

master: 100%

push

github

Reject null async bulk mappings and snapshot the result

AsyncBulkCompleter read the caller's result map lazily while
completing each proxy (a get in fillProxies, iteration in
addNewEntries), so a map whose get or traversal threw partway
stranded the remaining proxies as incomplete futures in the cache.
Snapshot the result with Map.copyOf up front so a misbehaving map
fails the batch cleanly. Map.copyOf also rejects null values, so a
null mapping now fails the load instead of being silently dropped,
matching the sync bulk path and Guava; this reverts a680a89ea, whose
silent drop masked buggy loaders.

Also disable the ImmutableMapCopyOf Refaster rule, whose suggested
ImmutableMap.copyOf is Guava — not on the main sourceSet — joining
its already-disabled ImmutableMapOf/Builder siblings.

4123 of 4132 branches covered (99.78%)

16 of 16 new or added lines in 1 file covered. (100.0%)

8394 of 8394 relevant lines covered (100.0%)

1.0 hits per line