medplum / medplum / 29134437041

92%

main: 92%

push

github

fix(server): prevent agent version clobber on connect status update (#9828)

* fix(server): prevent agent version clobber on connect status update

The agent WebSocket connect handler sent 'agent:connect:response' before
awaiting the agent status update in Redis. The status update is a
non-atomic read-modify-write (GET last info, SET merged status), so a
slow GET reply could resume after the agent's heartbeat response was
recorded, overwriting the reported version with stale info. This caused
the flaky 'Heartbeat' test failure on CI (version 'unknown' instead of
MEDPLUM_VERSION).

Complete the status update before acknowledging the connection, and add
a regression test that reproduces the race deterministically by
delaying the first agent info GET reply.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

* test(server): fix type error in heartbeat version test

Use sendText(JSON.stringify(...)) like the rest of the file -- sendJson's
JsonValue param rejects agent.id being string | undefined.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

---------

Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

22083 of 25083 branches covered (88.04%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

39276 of 41674 relevant lines covered (94.25%)

12375.09 hits per line