bodgit / sevenzip / 29130351630

75%

push

github

fix: return EOF when buffer is empty (#476)

* fix: return EOF when buffer is empty

The bra reader could return invalid results when a read ended
exactly so no data was left: In this case, the rc.rc read returned
(0, EOF), rc.n was 0. Therefore the rc.buf.Read() was called with
an empty slice, which caused it to return (0, nil), which was
then returned to the caller, and left the reader in the same
state as before.
In combination with e.g. io.ReadAll, this could cause an endless
loop.

* test: add test case for read loop

* test: Tweak test case

* Rename the test and example archive to make it slightly more obvious
  which filter is tested and tie it to the GitHub PR number.
* Wrap the test with a timeout so without the fix the test times out
  quickly rather than just spinning until the overall test timeout triggers.

---------

Co-authored-by: Max Altgelt <max.altgelt@nextron-systems.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

1872 of 2484 relevant lines covered (75.36%)

0.85 hits per line