jzombie / term-wm / 29128907872

75%

Build Type

push

github

Committed by web-flow

Commit Message

feat: Windows platform hardening, cross-platform test coverage, and regression safeguards  (#102)

* feat: Windows platform hardening, cross-platform test coverage, and
regression safeguards (0.8.19-alpha)
Addresses multiple Windows-specific reliability issues and establishes
comprehensive test coverage to prevent regressions across platforms.
Windows ConPTY lifecycle fixes:
- Synthesize PtyStatus::Exited callback in has_exited() when child
  process dies, preventing reader thread deadlock when ConPTY swallows
  EOF
- Clamp poll interval to 50ms on Windows (WINDOWS_MAX_POLL_INTERVAL) to
  prevent ConPTY thread starvation
- Activate native Windows FFI via kernel32 module:
  CreateToolhelp32Snapshot, OpenProcess, QueryFullProcessImageNameW for
  process tree walking and foreground process name detection
  Input normalization:
- Normalize events through KeyboardNormalizer in both drain_pending()
  and poll(), filtering Release (all platforms) and Repeat (Windows)
  before they reach the event buffer
- Remove esc_down stateful tracking from KeyboardNormalizer — now a unit
  struct. Esc deduplication handled by window manager's
  super_passthrough_window timeout instead of dropping presses
  Selection coordinate fix:
- Rewrite selection_text_for_range with ScrollbackGuard RAII guard for
  safe scrollback position restoration
- Extract max_scrollback before locking parser to prevent Mutex
  deadlocks
- Paginated extraction loop handles selections spanning
  viewport/scrollback boundaries using translated vt100 coordinates
  Cross-platform test infrastructure:
- Add get_test_executable() helper returning cat (Unix) or cmd.exe
  (Windows), replacing all 11 hardcoded "cat" strings in PTY tests
- 10 new tests covering: has_exited() callback firing and idempotency,
  event normalization in drain/poll, header_buttons() glyph and
  ordering, scrollback selection with small max_sb,
  WINDOWS_MAX_POLL_INTERVAL value, and Repeat key passthrough behavior
  Other:
- Cl... (continued)

Coverage Stats

268 of 284 new or added lines in 5 files covered. (94.37%)

2 existing lines in 1 file now uncovered.

21203 of 28646 relevant lines covered (74.02%)

201.32 hits per line