ossuminc / riddl / 29128886643

65%

main: 65%

Build Type

push

Committed by reid-spencer

Commit Message

Quote special-character identifiers in Identifier.format and prettify

RIDDL identifiers may be single-quoted to carry special characters
(spaces, /, @, etc.), and the parser accepts that form. The prettifier
emitted them unquoted, so parse -> prettify -> parse was not a round-trip
for such names (e.g. a user named 'CI/CD Pipeline').

- Identifier.format now single-quotes non-bare names. Adds public
  Identifier.isBareIdentifier(String) and Identifier.format(String),
  matching CommonParser.simpleIdentifier ([A-Za-z][A-Za-z0-9_-]*) and the
  EBNF simple_identifier rule exactly. Hyphens are bare (correcting the
  original proposal); empty stays empty.
- PathIdentifier.format wraps a whole path in one pair of quotes when any
  component is special ('a.CI/CD Pipeline.c') rather than quoting each
  component.
- Parser: pathIdentifier gains a whole-path quoted form
  (dottedPathIdentifier | quotedPathIdentifier); the dotted form is tried
  first so existing inputs (including per-component a.'x'.b) parse
  unchanged. EBNF grammar updated and GBNF regenerated; both the TatSu
  EBNF validator and the GBNF validator pass.
- Prettifier: five emit sites that rendered names via raw .id.value
  (including user names -- the reported repro) now go through .id.format.
- Display: format() is also used by identify() and error-message
  templates, which supply their own quotes. The two identify methods plus
  13 direct templates now use the raw value/path inside those quotes, so
  special and synthetic names (e.g. OnMessageClause 'command DooFoo') are
  not double-quoted. Restores exact pre-change message output.

Tests: ASTTest covers Identifier.format (bare, hyphen, special,
digit-leading, full quoted charset, empty), isBareIdentifier, and
PathIdentifier whole-path quoting; new IdentifierQuotingRoundTripTest
covers parse -> prettify -> parse fidelity for a special-char user, type,
and path reference. Green on JVM and Native; JS compiles.

Co-Authored-By: Claude Opus 4... (continued)

Coverage Stats

27 of 35 new or added lines in 7 files covered. (77.14%)

34 existing lines in 19 files now uncovered.

7697 of 11781 relevant lines covered (65.33%)

0.65 hits per line