rero / rero-mef / 29127123620

87%

staging: 87%

push

github

refactor(mef): dedupe MEF helpers, restore UI redirect nav links

* consolidate get_latest, replace_refs, add_information, and the
  three MEF indexers' bulk_index (new shared MefIndexer base),
  previously triplicated across agents/concepts/places mef/api.py,
  into EntityMefRecord in api_mef.py -- drops ~260 lines of
  near-identical per-family code
* fix two bugs found while deduplicating get_latest: the idref
  reverse lookup now iterates every match for a redirect_from hit
  instead of only checking the first (a record can be both
  redirect_to'd and redirect_from'd at once); the visited cycle-guard
  is now keyed by (pid_type, pid) instead of a bare pid
* strip index-only fields (entity, md5, pid_numeric,
  sort_authorized_access_point, type_conflict) from get_latest's
  output so it matches the record's public/schema-clean shape
* restore theme/views.py's redirect_to/redirect_from nav-link fix for
  the MEF detail page's Latest/Older buttons (own + reverse relation
  lookups), and extend it: when two sources (e.g. GND and IDREF)
  resolve to different targets, both are now shown, labelled by
  source, instead of one silently overriding the other
* fix add_information's metadata-copy loop, which was nested inside
  the outer error-status loop and reused its variable name, running
  redundantly instead of once
* add a shared strip_index_fields() test helper (tests/utils.py) to
  replace five copies of the same filtering dict-comprehension across
  the agents/concepts/places get_latest tests
* add mef_ui_query_parser (query.py), a dedicated parser for the MEF
  UI's own free-text search (all_mef_search in views.py). The UI's
  search box only has a bare term, unlike API consumers such as
  rero-ils's MEFProxyFactory, which already build a fully
  field-qualified q of their own (MEFProxyMixin._get_query_params).
  The new parser builds that same query clause, then routes it
  through the exact same unrestricted Q() construction as
  and_search_fact... (continued)

69 of 77 new or added lines in 8 files covered. (89.61%)

5442 of 6232 relevant lines covered (87.32%)

0.87 hits per line