spdx / tools-golang / 29122752175

86%

main: 86%

Build Type

Pull #291

github

Committed by arpitjain099

Commit Message

Guard against a nil *Package when reading JSON

A JSON document with a null entry in the packages array (for example
{"packages":[null]}) decodes to a nil *Package. The custom Document
unmarshaller walks d.Packages to build hasFiles relationships and
dereferenced that nil, so json.Read panicked instead of returning an
error-free document.

Skip nil package entries in the hasFiles loop, matching the existing
nil-relationships strip added for #238. Applied to both v2_2 and v2_3,
with a regression fixture and test in the json package.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>

Pull Request Pull Request #291: Guard against a nil *Package when reading JSON

Coverage Stats

4 of 4 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

7574 of 8759 relevant lines covered (86.47%)

18.6 hits per line