supabase / supabase-flutter / 29102073868
87%

DEFAULT BRANCH: main
Ran
Jobs 9
Files 95
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.062%. Remained the same
29102073868

push

github

web-flow 
test: remove abbreviations and code smells across package tests (#1584)

## What

Cleans up the test suites across every package. No production (`lib/`)
changes.

- **Abbreviations removed** in test-local identifiers: `res`/`getRes`/…
→ `response`/`result`, `req` → `request`, `params` → `parameters`, `msg`
→ `message`, `e`/`err` → `error`, `conn` → `connection`, `db` →
`database`, `at` → `accessToken`, `sig` → `signature`, `sub` →
`subscription`, and similar. Public API names, named arguments, JSON/map
keys and conventional acronyms (id, url, jwt, otp, pkce, ws, …) are left
untouched.
- **Weak assertions strengthened** with proper matchers: `isNotNull`,
`isEmpty`, `isTrue`/`isFalse`, `hasLength`, `contains`, `isA<T>()`,
`endsWith`, `isNot(contains(...))`. Redundant `.toString()`/casts and a
pointless cascade removed.
- **Idiomatic throw assertions**: converted `try { await op } catch (e)
{ expect(e, isA<X>()) }` and closure-wrapped `expectLater(() => future,
throwsA(...))` to `expectLater(future, throwsA(...))` (69 sites).
Genuinely synchronous `expect(() => syncCall(), throwsX)` and mockito
`when`/`verify` closures were left as-is.
- **Stale phone-auth tests fixed**: the two gotrue "should fail because
Twilio is not setup" tests were silently passing as no-ops (a
`try/catch` swallowed the non-exception). The test stack deliberately
enables phone auth, so they now assert the real success behavior.
- **Useless/duplicate tests removed (7)**:
- gotrue: four identical `same()` reference-equality tautologies
(`session`, `auth_exception`, `user`, `user_identity`).
- realtime: `socket_test` "calls callback" (incremented a counter
unconditionally, asserted nothing real).
- postgrest: "bulk insert with one row uses default value" (exact
duplicate).
- storage: "getPublicUrl leaves the URL unchanged when download is null"
(byte-for-byte duplicate).

## Testing

All package suites pass against a local Supabase stack: gotrue 446,
realtime 182, postgrest 177, stora... (continued)

4670 of 5364 relevant lines covered (87.06%)

4.05 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
90.0
 0.0% packages/postgrest/lib/src/postgrest_rpc_builder.dart
Jobs
ID Job ID Ran Files Coverage
1 gotrue - 29102073868.1 28
86.47
 GitHub Action Run
2 supabase_flutter - 29102073868.2 10
79.31
 GitHub Action Run
3 storage_client - 29102073868.3 6
93.96
 GitHub Action Run
4 realtime_client - 29102073868.4 11
89.61
 GitHub Action Run
5 functions_client - 29102073868.5 3
98.81
 GitHub Action Run
6 supabase_common - 29102073868.6 10
87.85
 GitHub Action Run
7 yet_another_json_isolate - 29102073868.7 1
77.78
 GitHub Action Run
8 postgrest - 29102073868.8 10
85.37
 GitHub Action Run
9 supabase - 29102073868.9 16
82.43
 GitHub Action Run
Source Files on build 29102073868