safe-global / safe-client-gateway / 29098733402

87%

push

github

fix(tests): resolve remaining flaky tests after Vitest migration (#3242)

* fix(tests): resolve post-Vitest flaky tests

Three tests kept flaking after #3139 (all surfaced via Datadog CI Pipeline
Health, which our log-scraping report missed once the suite moved to Vitest):

- name.builder: nameBuilder() sanitized (trimmed) the faker name and THEN
  truncated to NAME_MAX_LENGTH; the cut could land right after a space and
  re-introduce trailing whitespace, so sanitizeName(name) !== name. Re-sanitize
  after truncation so the result is a fixed point.
- bridge-name.entity.spec: the 'unknown bridge name' case used
  faker.word.noun(), which can itself be a bridge name (omni, polygon, across,
  gnosis, ...), making safeParse succeed and the assertion flip. Resample until
  the word is genuinely not a bridge name.
- integration specs: afterEach/afterAll called 'await app.close()' unguarded,
  so any beforeEach failure left app undefined and every test in the file
  reported 'Cannot read properties of undefined (reading close)' instead of the
  real error. Guarded with 'await app?.close()' across all integration specs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(tests): drop redundant if(app) guards before app?.close()

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

3693 of 4512 branches covered (81.85%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

9610 of 10786 relevant lines covered (89.1%)

507.7 hits per line