tomerfiliba / plumbum / 29097125243

88%

push

github

fix(session): keep the return code off the last line of output (#830)

* fix(session): keep the return code off the last line of output

The shell trailer ran `echo $?` right after the command, so when the
command's own output didn't end in a newline (say `printf abc`), the
return-code digits got appended to that last line. Parsing it as an int
then failed, returncode came back as the string "Unknown", and the real
output was corrupted or dropped entirely.

Print the return code on its own line with a leading newline, and strip
that one added newline back off the captured stdout so the output is
returned exactly as the command produced it. `printf abc` now gives
("abc", rc 0) instead of ("", "Unknown").

* fix(session): keep the stderr marker off the last line of output

The stderr trailer had the same gluing as the return code on stdout,
but worse: unterminated stderr output hid the end-marker entirely and
communicate() blocked forever. Print the marker on its own line and
strip the one injected newline, mirroring the stdout fix.

Assisted-by: ClaudeCode:claude-fable-5

---------

Co-authored-by: Henry Schreiner <henryfs@princeton.edu>

1328 of 1780 branches covered (74.61%)

5 of 5 new or added lines in 1 file covered. (100.0%)

5501 of 6284 relevant lines covered (87.54%)

12.42 hits per line