supabase / supabase-flutter / 29094096134

87%

push

github

fix(realtime_client): faster channel rejoin on web (#1471)

## What


### Faster disconnect

The previous `disconnect` first waited for the connection to get stable
by waiting for `conn.ready`. Despite the comment I added on it, I could
not find any issues by removing that wait and just close the connection
immediately. I tested this manually with the websocket channel package
by closing the connection instantaneously and with delays without
waiting for `conn.ready` on web, android and linux. This
[comment](https://github.com/dart-lang/http/issues/1693#issuecomment-2651080004)
seems to experience the same.
During testing on web, I found that by removing the wait for `ready` the
close is still not instantaneously, but can take several seconds. I
think it depends on the exact platform and state of the connection
whether this can save time or not.


### Timeout for connection close

During testing I experienced a real network issue at home, but no
reconnect was scheduled. I lost the exact logs, but when researching
other issues I came along this comment:
https://github.com/dart-lang/http/issues/1693#issuecomment-2651080004
which could be the source of the issue. The disconnect hang indefinitely
which is why no connect was scheduled. So I added a timeout to the
`conn.sink.close`. This may cause the disconnect to not wait for a
connection that would indeed close after like 10 seconds successfully,
but I don't think there is a real issue in handling this via a timeout.


### Faster Channel rejoin


In particular, I tested a Flutter web app on mobile by switching from
the browser to other apps and back. Only `inactive` and `hidden` events
are fired on web when switching to another app, which are currently not
handled by the app state handler in supabase_flutter. But those events
are also called when switching to another tab. But in the case of
switching to another tab the websocket connection is kept. When
switching to another app that is not the case and th... (continued)

13 of 14 new or added lines in 2 files covered. (92.86%)

4659 of 5356 relevant lines covered (86.99%)

4.04 hits per line