NVIDIA / holodeck / 29084340897

51%

main: 51%

Build Type

push

github

Committed by ArangoGutierrez

Commit Message

fix(cli): resolve contextcheck findings (thread ctx in os, nolint elsewhere)

golangci-lint v2.12.2's contextcheck linter newly flags 5 call chains
in cmd/cli now that v3 Actions receive a real context.Context (v2's
*cli.Context wasn't one).

- cmd/cli/os/os.go: thread the Action's ctx through runAMI into
  config.LoadDefaultConfig and ami.Resolver.Resolve, both of which
  already accept context.Context, replacing the two context.Background()
  calls. No pkg/ or internal/ signature changes needed.
- cmd/cli/cleanup, create, dryrun, update: the callee chains bottom out
  in pkg/cleanup.New, pkg/provider/aws.New, and
  pkg/provisioner.Dryrun -> internal/logger.Loading, none of which
  accept a context.Context by design (cleanup.New's own doc comment
  notes it is a top-level initializer without caller context).
  Threading real ctx would require pkg/ or internal/ signature changes,
  which are out of scope for this fix, so these sites are suppressed
  with //nolint:contextcheck and a one-line justification.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Coverage Stats

2 of 7 new or added lines in 3 files covered. (28.57%)

2 existing lines in 2 files now uncovered.

6532 of 12776 relevant lines covered (51.13%)

0.57 hits per line