supabase / supabase-flutter / 29081780486

87%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: modernize dart syntax across client packages (#1574)

## What

Sweeps the client packages for code that can use syntax introduced in
Dart 3.9 or earlier (our minimum SDK floor), and adds lint rules so new
code keeps to the modern style.

All changes are behavior-preserving refactors.

### Switch expressions (replacing value-returning switch statements /
if-else chains)
- `postgrest`: `textSearch` type mapping
- `realtime_client`: `connectionState`,
`PostgresChangeFilterType.token`, `PostgresChangeEvent.fromString`,
`ChannelEventsExtended.eventName`, `_binaryDecode`
- `gotrue`: `JWK operator[]`, `fetch` HTTP method dispatch,
`PhoneEnrollment._fromJsonValue`
- `supabase`: `_getPostgrestData` filter dispatch

### Null-aware collection elements (`{'k': ?v}`) and spreads (`...?`)
- `storage_client`: `ToQueryParams`
- `gotrue`: `JWK.toJson`, `getOAuthSignInUrl` url params

### Collection-for / spread (replacing `fold` / `addAll`)
- `postgrest`: `_setColumnsSearchParam`
- `storage_client`: `download` query merge

### if-case pattern (replacing manual `is` + cast)
- `postgrest`: `_handleMaybeSingleError`

## Lint rules added to `supabase_lints`
- `use_enums` (core)
- `unnecessary_breaks` (core)
- `prefer-switch-expression` (DCM)

Enum switches are kept exhaustive (no `_` wildcard) so
`avoid-wildcard-cases-with-enums` stays satisfied.

## Testing
- `dart analyze` clean across all packages with the new rules.
- `dcm analyze` reports no new issues (one pre-existing
`avoid-inferrable-type-arguments` in `gotrue_oauth_api.dart` is
untouched).
- Package test suites pass; remaining failures are pre-existing
integration tests that require a running local Supabase instance.

Closes SDK-1283

Coverage Stats

79 of 102 new or added lines in 14 files covered. (77.45%)

29 existing lines in 5 files now uncovered.

4655 of 5351 relevant lines covered (86.99%)

4.05 hits per line