tari-project / tari / 29077159165
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 703
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.952% (+0.1%) from 61.821%
29077159165

push

github

web-flow 
feat(installer): add unified Minotari Ledger installer (#7864)

Fixes #7795

## Summary
- Add one cross-platform Python installer for the Minotari Ledger Wallet
app.
- Detect supported Ledger devices with `ledgerwallet` target IDs and
report the original Nano S as unsupported.
- Resolve a matching Tari release artifact, require the `.zip.sha256`
sidecar, verify it, and safely extract the archive.
- Install current `minotari_ledger_wallet.apdu` artifacts through
`ledgerblue.runScript --scp`; legacy manifest fallback is intentionally
not supported.
- Keep the existing per-model scripts as thin compatibility wrappers
around the unified auto-detecting installer.
- Stage the unified installer and wrappers as release assets so
downloaded wrapper assets remain runnable.

## Correctness Note
The current stable Tari release may not include Ledger wallet assets,
while pre-releases do. The default lookup scans recent non-draft
releases, including pre-releases, and only selects a Ledger artifact
when both the model zip and matching checksum sidecar are present.

## Testing
- `uv run python
applications/minotari_ledger_wallet/wallet/install_scripts/test_install_minotari_ledger.py`
- `uv run python
applications/minotari_ledger_wallet/wallet/install_scripts/install_minotari_ledger.py
--help`
- `uv run python -m py_compile
applications/minotari_ledger_wallet/wallet/install_scripts/install_minotari_ledger.py
applications/minotari_ledger_wallet/wallet/install_scripts/test_install_minotari_ledger.py`
- `uvx ruff check
applications/minotari_ledger_wallet/wallet/install_scripts/install_minotari_ledger.py
applications/minotari_ledger_wallet/wallet/install_scripts/test_install_minotari_ledger.py`
- Repo-layout wrapper `--help` smoke test
- Flat release-asset wrapper `--help` smoke test
- `git diff --check`
- Real Nano S Plus hardware install succeeded after updating device
firmware to a compatible Ledger OS version.

---------

Co-authored-by: SW van Heerden <swvheerden@gmail.com>

72564 of 117129 relevant lines covered (61.95%)

223252.08 hits per line

Coverage Regressions

Lines Coverage ∆ File
12
53.38
 1.91% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
6
53.95
 0.12% base_layer/core/src/chain_storage/blockchain_database.rs
4
80.54
 -0.83% comms/core/src/noise/socket.rs
2
85.42
 -0.46% base_layer/p2p/src/services/liveness/service.rs
2
84.28
 0.0% comms/core/src/connection_manager/peer_connection.rs
2
81.22
 -0.94% comms/core/src/connectivity/peer_health.rs
1
46.97
 3.03% base_layer/core/src/chain_storage/block_add_result.rs
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
38.56
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
Jobs
ID Job ID Ran Files Coverage
1 29077159165.1 703
61.95
 GitHub Action Run
Source Files on build 29077159165