ponder-lab / Hybridize-Functions-Refactoring / #2410

81%

main: 83%

Build Type

Pull #752

github

Committed by khatchad

Commit Message

Harden the numpy shape precondition: poison ambiguous descriptors, cache the index

Two post-merge review findings on #750:

- colorShapeFrom let the last writer win when a value received shape provenance
  from two conflicting sources (e.g. a phi merge), which could "prove" staticness
  from one source only. Poison such a value to an ambiguous descriptor (null
  source, so it resolves to ⊤/unprovable), the conservative outcome.
- indexTensorTypes was rebuilt on every appliesNumpyToParameters call, i.e. per
  call-graph node of every function. Build it once per function and reuse it
  across the function's nodes; indexTensorTypes is now the shared entry point.

Behavior-preserving on the corpus and the unit fixtures (no conflicting
descriptors arise there); suite 570 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01He1ULx8nRoHzGicMryry1A

Pull Request Pull Request #752: Harden the numpy shape precondition: poison ambiguous descriptors and cache the type index

Coverage Stats

9 of 10 new or added lines in 2 files covered. (90.0%)

14 existing lines in 1 file now uncovered.

2078 of 2558 relevant lines covered (81.24%)

0.81 hits per line