29059453548
85%
master: 85%

Ran 10 Jul 2026 12:14AM UTC

Jobs 1

Files 53

Run time 1min

Badge

Embed ▾

Committed 09 Jul 2026 10:28PM UTC coverage: 84.547%. Remained the same

Build # 29059453548

Build Type

push

github

Committed by

umputun

Commit Message

Fix comments iframe collapsing to preloader height on load

On mount ConnectedRoot immediately reported the iframe height to the
parent page while the app was still showing the global preloader, so the
parent shrank the iframe from its initial size to ~63px and then grew it
back step by step as content rendered. On pages with many comments this
reads as the widget blinking several times before loading (reported for
radio-t.com). The June frontend dependency refresh (#2091) shifted
render/effect timing enough to make the premature measurement happen on
every load rather than only on slow connections.

Move the height reporting into Root and start it in the setState callback
that replaces the preloader with real content: the first height message
now always describes rendered content, the iframe never shrinks below it,
and subsequent ResizeObserver updates only grow the frame as comments
arrive. Also adds the previously missing observer disconnect on unmount.

Verified by instrumenting the embed with a height-message listener:
master sent 63px then 316px on an empty test page (v1.16.1 sent a single
316px); with this fix the first message is 316px again.

Coverage Stats

6478 of 7662 relevant lines covered (84.55%)

36.77 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	29059453548.1	10 Jul 2026 12:14AM UTC	53	84.55	GitHub Action Run

umputun / remark42 / 29059453548
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 29059453548

umputun / remark42 / 29059453548 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 29059453548

umputun / remark42 / 29059453548
85%
master: 85%

README BADGES
x