medplum / medplum / 29051108017

92%

push

github

test(agent,hl7): fix flaky `getFreePort` port collision (#9804)

* test(agent): fix flaky getFreePort port collision

getFreePort closed its probe server before returning, so two sequential
calls could be handed the same ephemeral port by the OS. Tests that
allocate multiple ports (e.g. the 'test' and 'prod' channels in
"Setting a channel.endpoint.status to 'off'") then declared the same
port and app.start() threw a config conflict.

Remember every issued port and hold a probe server open when it lands on
an already-issued port, so the OS can't reissue it in the same round.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

* test(hl7): fix flaky getFreePort port collision

Mirror the agent package fix: getFreePort closed its probe server before
returning, so two sequential calls could be handed the same ephemeral
port by the OS. Remember every issued port and hold a probe server open
when it lands on an already-issued port, so the OS can't reissue it in
the same round.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

* refactor(hl7): export getFreePort from @medplum/hl7 as single impl

The flaky-port fix previously lived duplicated in both the agent and hl7
test-utils. Consolidate it into one implementation in
packages/hl7/src/free-port.ts, exported from the package's public API, and
have both packages import it directly:

- hl7's own tests import from './free-port'
- the agent package imports from '@medplum/hl7'

free-port.ts is a standalone, vitest-free module so it can be exported from
the runtime index without pulling test-only globals into the bundle.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

* refactor(hl7): extract MAX_ATTEMPTS constant in free-port

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>

*... (continued)

21972 of 24958 branches covered (88.04%)

Branch coverage included in aggregate %.

18 of 21 new or added lines in 1 file covered. (85.71%)

39113 of 41489 relevant lines covered (94.27%)

12419.0 hits per line