kubevirt / hyperconverged-cluster-operator / 29043567111

82%

push

github

CNV-92360: v1 API version: make feature gate names case-insensitive (#4384)

* add the 'generate-crd' make target to create the CRD

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* make v1 FG to be case-insensitive

Also, make sure the feature gate are unique in the FeatureGates list.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* regenerate CRDs

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* add functional tests

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* do marshal the state field if exists and enabled

we only marshal the FeatureGate state field if it disabled, but k8s
marshling sometimes keeps it even if it Enabled, so for consistency, we
now marshaling the state field if exists, no matter its value.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Preserve v1 only FGs

The automatic conversion only handles feature gates that are defined in
both v1beta1 and v1 API versions. Any feature gate tat is not defined in
v1beta1, will be lost in conversion.

This commit preserves all v1 feature gates using the v1-only-fields
mechanism.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

18 of 18 new or added lines in 3 files covered. (100.0%)

11319 of 13882 relevant lines covered (81.54%)

2.18 hits per line