source-academy / py-slang / 29027177528

78%

push

github

Fix stepper's max/min to require >=2 args, matching CSE and PVML (#248)

* Fix stepper's max/min to require >=2 args, matching CSE and PVML

The substitution stepper's selectExtreme() called checkArity(name,
args, 1, null) and BUILTIN_MIN_ARGS listed max/min as 1, so max(5)
silently returned 5 and arity(max) reported 1 -- both CSE machine
(@Validate(2, null, "max", true) in misc.ts) and PVML (explicit
args.length < 2 check in builtins.ts) correctly require >=2 direct
arguments and have no single-iterable form (unlike CPython's
max([1, 2, 3])). Fix the stepper to match.

Add the missing test coverage this gap slipped through: CSE gained a
"max/min" functional+arity block (stdlib.test.ts) and a chapter-3
"max/min: no single-iterable form" block covering the borderline case
max(pair(1, 5)) -- a pair is a two-element Python list under the hood,
so it looks like the form CPython accepts, but still hits the same
arity gate as any other single argument. The stepper gained an
equivalent test in getSteps.test.ts.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Format getSteps.test.ts (fixes failing yarn format:ci check)

A line from the earlier max/min arity test stayed multi-line past
what prettier now wants; never reformatted before pushing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

2670 of 3725 branches covered (71.68%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

6199 of 7702 relevant lines covered (80.49%)

12679.75 hits per line