openbraininstitute / libsonata / 29009708706

Pull #56

github

Address review: rename ElectrodeDataFrame, simplify I/O, harden validation

- Rename ElectrodeDataFrame → ElectrodeScalingFactors (avoids confusion
  with report DataFrame and pandas)
- Use Path directly in Python test (no str() needed)
- Store electrode positions as float (matches HDF5 float32, no widening)
- Throw on malformed position dataset (instead of silent zero-fill)
- Hoist read buffer outside loop in readAndScatter (avoid reallocation)
- Introduce IOBlock struct with file row boundaries (no -1 indirection)
- Refactor coalesceIOBlocks loop to start from 1 (cleaner half-open logic)
- discoverElectrodeMetadata writes member vectors directly (remove ElectrodeInfo)
- Remove redundant comments where function name is self-documenting
- Add test for bad position dataset throw

197 of 209 new or added lines in 1 file covered. (94.26%)

2711 of 2916 relevant lines covered (92.97%)

49.12 hits per line