rero / rero-mef / 29008989430

87%

push

github

fix(mef): resolve redirects via any linked source, not just one

* get_latest() only checked the redirect on the pid_type it was
  called with; add a shared _find_redirect_target() on
  EntityMefRecord that checks every linked source (idref, gnd,
  rero) instead, fixing lookups like
  /agents/mef/latest/gnd:X when only the idref source redirected
* de-duplicate three byte-for-byte identical (and buggy) get_latest
  implementations in agents/concepts/places mef api.py into that
  shared base class method
* theme/views.py: _compute_nav_urls had the same gap for the MEF
  detail page's Latest/Older buttons; add the missing reverse
  redirect_from lookup and extract _own_relation_url /
  _reverse_relation_urls for readability and testability
* add regression tests: a deterministic _find_redirect_target unit
  test (avoids relying on ambiguous Elasticsearch ordering) and a UI
  test for the previously-missing Latest button

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

61 of 68 new or added lines in 2 files covered. (89.71%)

5488 of 6282 relevant lines covered (87.36%)

0.87 hits per line