umputun / agterm / 29006554395
98%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.174%. Remained the same
29006554395

push

github

web-flow 
fix: keep keyboard focus on the overlay/scratch, not the pane behind it (#182)

* fix: restore sidebar focus to the topmost surface, not the covered pane

focusActiveTerminal handed first responder to the active session's main pane
regardless of what covered it, so a sidebar click while an overlay or the
scratch terminal was up sent keystrokes to the shell behind them. The overlay
stayed on screen and silently stopped receiving input.

Route the restore through Session.topmostSurface (overlay, else scratch, else
the active pane) — the accessor the other focus paths already share. As a
consequence a sidebar click on a split session now focuses the focused pane
rather than always the main one, which is the intended behavior.

Covered by testSidebarClickKeepsFocusOnOverlayNotPaneBehind: a floating
overlay whose shell captures one keyboard line, a click on the session row,
then a typed marker that must reach the overlay.

* fix(review-loop): iteration 1 addressed 5 findings

- [major] [agterm/agtermApp.swift:219,337] onExit refocus resolved activeSurface,
  so a pane shell exiting under an overlay/scratch stole focus to the covered
  pane — the same defect class as the sidebar fix. Now resolves topmostSurface.
- [major] [agtermUITests/ControlOverlaySplitUITests.swift] the test could pass on
  a buggy build: the overlay's auto-focus retry runs 2.0s (40x0.05s), longer than
  the 800ms settle, so it could re-grab focus after a steal. Added a pre-click
  marker that proves the cover holds focus before the click, plus an isHittable
  assert on the row.
- [test-gap] [agtermUITests/ControlOverlaySplitUITests.swift] added
  testSidebarClickKeepsFocusOnScratchNotPaneBehind, covering the scratch branch
  of topmostSurface (verified failing pre-fix).
- [doc-gap] [agterm/Views/WorkspaceSidebar.swift:656] doc comment claimed the
  cover hides the pane, false for the floating overlay the test exercises.
- [doc-gap] [agtermCore/Sources/agtermCore/Session.swift:311] doc ... (continued)

4302 of 4382 relevant lines covered (98.17%)

6861121.14 hits per line

Jobs
ID Job ID Ran Files Coverage
1 29006554395.1 59
98.17
 GitHub Action Run
Source Files on build 29006554395