raystack / frontier / 29002980359

45%

main: 45%

Build Type

Pull #1744

github

Committed by whoAbhishekSah

Commit Message

fix(invitation): auto-delete expired invitations on a schedule

Nothing removed an invitation once it expired. Trying to accept an
expired invite just fails with an error, and creating a new invite for
the same user writes over the old one — neither path deletes the expired
invite. So an invite that was never accepted or deleted kept its
invitations row and both SpiceDB tuples (#user and #org) forever.

Add a daily background job (robfig/cron, "0 0 * * *" UTC, same pattern
as the domain-verification and session-cleanup jobs) that finds expired
invitations and deletes them.

The job deletes through the existing invitation.Delete, which removes
both SpiceDB tuples and the invitations row together. This is important:
the repository's old GarbageCollect ran a raw row DELETE, which would
have left the SpiceDB tuples behind as orphans. GarbageCollect is
removed and replaced with a read-only ListExpired that the service
iterates over.

- core/invitation: InitInvitationCleanup / DeleteExpiredInvitations /
  Close, and a ListExpired repository method.
- cmd/serve: start the job at boot and stop it on shutdown, next to the
  other periodic jobs.
- store/postgres: GarbageCollect -> ListExpired.
- tests for the sweep and for ListExpired.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1744: fix(invitation): auto-delete expired invitations on a schedule

Coverage Stats

27 of 57 new or added lines in 3 files covered. (47.37%)

46 existing lines in 2 files now uncovered.

16904 of 37665 relevant lines covered (44.88%)

12.5 hits per line