supabase / supabase-flutter / 28997985907

87%

push

github

fix(storage): guard against empty transform routing through render endpoint (#1551)

## Summary

An empty or default `TransformOptions()` was routing `download()` and
`getPublicUrl()` through the `/render/image/` endpoint unnecessarily.
Previously the decision was based on `transform != null`, so any
`TransformOptions` instance, even one with all-null fields, switched to
the render path. Now routing only switches to the render endpoint when
the transform options actually produce query parameters.

**Outcome:** implemented (bug fix)

## Behavior

- `download(path)` without transform uses `/object/` endpoint
- `download(path, transform: TransformOptions())` with empty transform
uses `/object/` endpoint
- `download(path, transform: TransformOptions(width: 200))` uses
`/render/image/authenticated/` endpoint
- Same logic for `getPublicUrl()`

## Tests

Added unit tests in `packages/storage_client/test/basic_test.dart`
covering empty vs actual transform routing for both `download()` and
`getPublicUrl()`. All storage_client unit tests pass.

## Reference

- Linear: SDK-878
- supabase-js PR: https://github.com/supabase/supabase-js/pull/2219
(commit `993bb5fc`)

## Compliance matrix

`storage.file_buckets.download_with_transform` and
`storage.file_buckets.get_public_url` remain `implemented`; this fix
brings their routing behavior in line with supabase-js, so no status
change was required.

4 of 4 new or added lines in 1 file covered. (100.0%)

4466 of 5167 relevant lines covered (86.43%)

3.99 hits per line