dangernoodle-io / breadboard / 28996089667

95%

push

github

refactor: remove bb_pub_fan/power/thermal failed-DI pub-sink glue (#794)

bb_pub_fan, bb_pub_power, and bb_pub_thermal were legacy DI/registry
glue (BB_INIT_REGISTER_PRE_HTTP, per-satellite AUTO_ATTACH kconfig,
pre_http force-register) duplicating telemetry already owned by
bb_sensors' /api/sensors section producers (bb_fan_emit_section,
bb_power_emit_section, bb_thermal_emit_section), each of which shares
the same SSOT builder (bb_fan_emit, bb_power_emit, bb_thermal_collect)
the removed satellites called under the hood. GET /api/sensors is
unaffected. bb_pub_health is NOT touched — its heap_state field has no
live-route equivalent (audited, kept per B1-133 scope).

- Field-fidelity coverage (null/NaN/-1 semantics, autofan fields,
  present/absent nesting) already lives on the surviving emit-path
  tests (test_bb_fan_emit.c, test_bb_power_emit.c,
  test_bb_thermal_collect.c, test_bb_sensors.c) with no gaps, so no
  assertions needed to move; deleted test_bb_pub_fan.c,
  test_bb_pub_power.c, test_bb_pub_thermal.c, and the now-moot
  pub-vs-emit parity blocks in test_bb_pub_parity.c and the
  satellite SSOT-fidelity blocks in test_bb_pub_telemetry_fidelity.c
  (the generic SSOT serialize-once/REST-equals-sink invariants remain
  covered by that file's synthetic "telem_fid" harness).
- Pruned the 12 associated di_legacy fence entries (4 per satellite)
  and 3 new_component entries via `fence --update-baseline`
  (di_legacy 322 -> 310, new_component 125 -> 122).

3413 of 3413 branches covered (100.0%)

Branch coverage included in aggregate %.

5431 of 5431 relevant lines covered (100.0%)

9833.5 hits per line