decentraland / worlds-content-server / 28988679752

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: guard GC pending-key projection and store all uploaded files

- getActivePendingKeys: guard the jsonb content projection with
  jsonb_typeof(entity->'content') = 'array'. jsonb_array_elements raises on a
  scalar/object/json-null, so one pending row with a non-array content would
  fail the whole query and wedge garbage collection server-wide until it
  expired; the JS code this replaced tolerated it via `?? []`
- storeFiles: store every uploaded file unconditionally instead of skipping
  from a pre-upsert storage snapshot, which could discard bytes uploaded in a
  batch if the file was swept before the store; content-addressed re-store is
  an idempotent no-op and the client already omits already-present files

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1463 of 1753 branches covered (83.46%)

Branch coverage included in aggregate %.

145 of 162 new or added lines in 9 files covered. (89.51%)

4 existing lines in 3 files now uncovered.

3117 of 3398 relevant lines covered (91.73%)

86.73 hits per line