kubernetes-sigs / karpenter / 28980695188

82%

main: 82%

Build Type

Pull #2894

github

Committed by nathangeology

Commit Message

test(deletioncost): document single-error-aborts-all reconcile behavior

Adds a spec that documents the current behavior when a shared dependency
(here: the PDB list) fails during Reconcile: the entire reconcile aborts
and no NodePool's pods get annotated in that cycle. The test wraps the
kubeClient to fail List of PodDisruptionBudgetList only and asserts that
pods on a healthy NodePool (unrelated to the disrupted one that triggers
fetchPDBs) also come out unannotated.

The test name is prefixed _Deferred_ and references the follow-up bead
(kp-dses9q) so a future reviewer can trace back to why this is being
documented rather than changed. Once RankNodes fans out per-NodePool
with multierr this assertion should flip to expect healthy NodePools'
pods to still get annotated.

No production code changes.

Pull Request Pull Request #2894: feat: Add feature-gated pod deletion cost management controller

Coverage Stats

439 of 511 new or added lines in 8 files covered. (85.91%)

3 existing lines in 2 files now uncovered.

16693 of 20312 relevant lines covered (82.18%)

96871.07 hits per line