tecnickcom / gogen / 28977817959

100%

push

github

feat(devlake)!: sentinel errors, nil-request guards, shared retrier, and response hardening

Harden the DevLake webhook client to match the conventions of the recently-hardened sibling packages: exported sentinel errors, construction-time retry validation, a single shared retrier that honors Retry-After, nil-request guards instead of panics, and bounded response-body handling.

Features:

- Add exported sentinel errors ErrInvalidAddress, ErrEmptyAPIKey, ErrInvalidRetryConfig, and ErrNilRequest, all wrapped with %w so callers can match them via errors.Is.
- Build a single immutable httpretrier in New instead of constructing one per request, and honor a server-provided Retry-After header capped at 60s.
- Drain response bodies (capped with io.LimitReader) on the health-check and send paths so idle connections can be reused, and append a capped, trimmed snippet of a non-2xx response body to the returned error to aid debugging.
- Remove the unused baseURL field and document that WithTimeout has no effect on an injected HTTP client.

Fixes:

- Return ErrNilRequest from SendDeployment, SendIncident, and SendIncidentClose instead of dereferencing a nil request and panicking.

Breaking changes:

- New now validates retry options and returns an error matching ErrInvalidRetryConfig at construction instead of failing on the first send, retries now wait for a server-provided Retry-After, and error message texts changed.

36 of 36 new or added lines in 1 file covered. (100.0%)

15203 of 15205 relevant lines covered (99.99%)

1035.39 hits per line