bstoll / kne / 28976590405
42%
main: 42%

LAST BUILD BRANCH: hines-fork
DEFAULT BRANCH: main
Ran
Jobs 1
Files 58
Run time 19225min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 41.978% (-0.08%) from 42.058%
28976590405

Pull #10

github

bstoll 
Fix golangci-lint violations and format YAML/Go files

This change aggregates several fixes to address golangci-lint violations, format code files, and update deprecated APIs.

Key changes:
- Refactored Go code to address golangci-lint violations and update deprecated APIs:
  - Replaced deprecated `k8s.io/utils/pointer` with `k8s.io/utils/ptr`.
  - Replaced deprecated `grpc.DialContext` with `grpc.NewClient`.
  - Handled or logged errors from `CloseSend`, `ReadFrom`, `BindPFlags`, etc.
  - Standardized error message capitalization (removed leading capitals and ending punctuation).
  - Simplified boolean expressions and struct field accesses.
  - Addressed various linter-raised spelling errors and style comments (e.g. in `topo/node/sonic` and other nodes).
  - Renamed internal fields for better readability (e.g., `wantInitCtr` to `wantInitContainer` and `wantSonicCtr` to `wantSonicContainer` in `sonic.go`).
- Ran `go fmt` across all Go source files.
- Formatted YAML files and manifests according to linter configurations (added `---` document start markers, fixed spacing/indentation in cloudbuild config, deployments, and various topological templates).
- Updated configuration files for Super-Linter:
  - Added codespell configuration file `.github/linters/.codespellrc`.
  - Adjusted `.golangci.yml` linter settings.
  - Added rules to `.github/linters/.checkov.yaml`, `.github/linters/.gitleaks.toml`, etc.
  - Added dependency cooldown periods in `.github/dependabot.yml`.
- Ran Prettier on all Markdown files in the repository to ensure consistent styling.
Pull Request #10: Golangci lint fixes

5186 of 12354 relevant lines covered (41.98%)

0.48 hits per line

Coverage Regressions

Lines Coverage ∆ File
159
61.77
 -0.13% deploy/deploy.go
54
80.45
 -0.26% topo/topo.go
35
89.61
 -0.3% topo/node/cisco/cisco.go
24
31.39
 -0.24% topo/node/node.go
20
4.91
 -0.06% cmd/root.go
15
36.3
 -0.5% x/wire/wire.go
11
89.1
 0.0% topo/node/sonic/sonic.go
9
58.7
 -4.35% api/metallb/clientset/v1beta1/client.go
4
0.0
 0.0% x/webhook/main.go
4
0.0
 0.0% x/wire/file/client/main.go
4
0.0
 0.0% x/wire/forward/main.go
4
0.0
 0.0% x/wire/intf/client/main.go
2
0.0
 0.0% flags/flags.go
Jobs
ID Job ID Ran Files Coverage
1 28976590405.1 58
41.98
 GitHub Action Run
Source Files on build 28976590405