clear-street / reinforcer / 28975728178

59%

push

github

Migrate off deprecated packagestest, modernize for Go 1.26 (#14)

* Migrate off golang.org/x/tools/go/packages/packagestest

packagestest moved to an internal-only package as of x/tools v0.35.0
(golang/go#70229), so any future dependency bump would break the build.
Replace it with a small test helper that writes a real go.mod + fixture
files under t.TempDir() and drives packages.Load in module mode instead
of packagestest's GOPATH exporter.

Bump golang.org/x/tools to v0.47.0 to prove the migration holds against
the version where packagestest actually disappeared from the public API.

* Modernize codebase with go fix, narrow CI matrix to 1.25.x/1.26.x

Run go fix under a Go 1.26 toolchain to pick up automatic modernizations
gated by the module's go 1.25 floor: any -> interface{} replacement,
range-over-int, and the new go/types iterator methods (TypeParams,
Methods, Variables) in place of manual index loops. Also drop the
now-redundant loop-variable shadow copies go fix left behind, since
Go 1.22+ scopes loop variables per iteration.

Update the CI test matrix to match the go.mod floor raised by the
x/tools bump (dropping 1.21.x-1.23.x, adding 1.26.x for forward coverage).

* Regenerate stale example output

example/client/reinforced/*.go had drifted from its own source of truth:
still emitting interface{} instead of any (client.go already switched to
any in a prior commit), missing the context.WithValue call generateCommon
has added since, and missing the per-type Methods constant structs the
generator now inlines instead of writing to a shared file. Re-ran the
package's documented go:generate directive to bring it back in sync, and
removed reinforcer_constants.go, the now-obsolete shared file the current
generator no longer produces.

* Finish host-side loop modernization in method.go and retryable.go

These loops build jen.Code at generation time and never touch emitted
output, but they were the same C-style index-loop shape as the ones
converted i... (continued)

11 of 36 new or added lines in 8 files covered. (30.56%)

799 of 1352 relevant lines covered (59.1%)

6.06 hits per line