kubeflow / sdk / 28942921718

83%

push

github

fix(trainer): validate HuggingFaceModelInitializer storage_uri has a repo path (#564)

HuggingFaceModelInitializer only checked the hf:// prefix, while its
sibling HuggingFaceDatasetInitializer also rejects a storage_uri whose
urlparse path is empty. A model storage_uri such as hf://model was
silently accepted and only failed later at download time.

Add the same repo path guard to the model initializer so an invalid
storage_uri raises ValueError at construction with a clear message. Add
parametrized tests for HuggingFaceModelInitializer, which had no prior
coverage.

Fixes #563

Signed-off-by: Sahil Kumar Singh <sahilkumargreat12@gmail.com>

13 of 13 new or added lines in 2 files covered. (100.0%)

5062 of 6075 relevant lines covered (83.33%)

1.67 hits per line