supabase / supavisor / 28941179061

77%

Build Type

push

github

Committed by web-flow

Commit Message

fix(client_handler): wire in client_idle_timeout (#1068)

## What kind of change does this PR introduce?

Bug fix: Fixes and wires in the broken `client_idle_timeout`
functionality.

## What is the current behavior?

`client_idle_timeout` silently does nothing. Idle connections are never
being closed. The client_handler gen_statem has been firing a mismatched
timeout event since #377.

## What is the new behavior?

Fixed the mismatch and also decoupled the timer to a state timeout,
which makes more sense semantically and avoids the messy mix-up with the
heartbeat timer. The heartbeat timer keeps using the event timeout.

## Additional context

Also stitched a simple integration test for this, taking help from
helpers in `protocol_integration_test.exs`.

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

8 existing lines in 7 files now uncovered.

2569 of 3362 relevant lines covered (76.41%)

54798.48 hits per line