tecnickcom / gogen / 28938710952

100%

push

github

feat(passwordhash)!: parameter envelope, rehash API, sentinel errors, and hardening

Harden the Argon2id password hashing package against misconfiguration, forged input, and operational foot-guns, add a verifier-based rehash API and a complete sentinel-error taxonomy, and make hashing parameters machine-independent.

- Guarantee that any hash the package can mint it can also verify: the cost options (WithTime, WithMemory, WithKeyLen, WithSaltLen) now clamp to the same [floor, ceiling] range the verification path accepts, and hashing rejects out-of-envelope configurations — previously a value such as WithTime(2000) minted hashes that no verification could ever accept.
- Replace panics with errors: hashing validates its configuration and returns ErrInvalidParams for a zero-value or mutated Params (missing random source, out-of-range cost, non-argon2id algorithm or version) instead of panicking inside argon2; verification and the rehash checks reject an uninitialized receiver the same way.
- Harden verification against forged or corrupt blobs: reject encoded hash strings larger than 16 KiB before any decoding, validate the deserialized parameters against their accepted bounds, and cross-check that the salt and key byte lengths match their declared sizes.
- Add a complete sentinel-error taxonomy matchable with errors.Is: ErrPasswordTooShort, ErrPasswordTooLong, ErrInvalidParams, ErrInvalidHashData (including decode, decrypt, and oversize failures), ErrAlgoMismatch, ErrVersionMismatch, and ErrInvalidPepperKey.
- Add PasswordNeedsRehash and EncryptPasswordNeedsRehash to detect hashes minted with outdated parameters, enabling transparent re-hashing on the next successful login.
- Default parallelism is now a flat 4 lanes (RFC 9106 §4) instead of runtime.NumCPU(), so minted hashes are reproducible across heterogeneous hardware and a mixed fleet cannot enter a rehash loop; the key and salt minimums for new hashes are raised to 16 and 8 bytes.
- Enforce the min... (continued)

170 of 170 new or added lines in 2 files covered. (100.0%)

15038 of 15040 relevant lines covered (99.99%)

976.87 hits per line