codenotary / immudb / 28933776347

85%

Build Type

push

gh-ci

Committed by vchaindz

Commit Message

fix(database): guard nil db in DBManager.CloseAll to avoid shutdown panic

A database whose open failed leaves a db-less ref in the cache: Get() has
allocDB Put() a &dbRef{count: 1}, openDB then fails and Release() only
decrements the count without removing the entry. On shutdown, CloseAll
iterated that ref and called ref.db.Close() on a nil db, panicking with a
nil pointer dereference and truncating the graceful shutdown.

Guard ref.db != nil in CloseAll, mirroring every other close site in the
file (OnEvict, Close, Release). Add a regression test reproducing the
failed-open-then-shutdown path.

Fixes #2108

Signed-off-by: Damien Sauvée <damien.sauvee@recommerce.com>

Coverage Stats

5 of 7 new or added lines in 1 file covered. (71.43%)

8 existing lines in 3 files now uncovered.

45227 of 53225 relevant lines covered (84.97%)

125983.45 hits per line