vbpf / prevail / 28930708353
86%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 78
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.497% (-0.008%) from 86.505%
28930708353

push

github

web-flow 
Fix packaging and CI configuration gaps (#1186)

Addresses most of #1173:

- ENABLE_ASAN now produces a working sanitized build: ASan is applied as a
  PUBLIC usage requirement with matching link options (GCC/Clang) and MSVC
  handling, so the CLI, tests, and consumers linking `prevail` are all
  instrumented and link. Still behind ENABLE_ASAN (default OFF).
- prevailConfig.cmake.in resolves Boost with a non-required find_package so
  consumption does not hard-fail on the MSVC/NuGet headers-only path.
- Export the C++ standard as a usage requirement: target_compile_features(
  prevail PUBLIC cxx_std_20).
- Pin coverallsapp/github-action to @v2 (was @master).
- Include the Boost version in the Windows NuGet cache key (build.yml,
  release.yaml) via a BOOST_VERSION env var, so a version bump invalidates
  the stale cache.

Deferred: enabling the install/consume CI workflow (test-installation.yml).
Turning it on surfaced pre-existing, multi-OS breakage that is out of scope
to fix reliably here: the workflow provisions no build dependencies (Boost
missing on ubuntu/macOS), and the Windows install/consume path fails at the
consumer's find_package(prevail) (installed config not located). These warrant
a dedicated follow-up; the file is left as .example for now.

* Revert speculative Boost consume change; defer to install-CI follow-up

Addressing review feedback (P1): find_package(Boost QUIET) does not actually
make the installed package consumable. prevail::prevail publicly links
Boost::headers (when built against it) and installed headers include Boost, so
a consumer whose machine lacks a Boost CMake package would find prevail and then
fail at target import/compile -- and unlike find_dependency(Boost REQUIRED), the
non-required find_package fails late and cryptically instead of loudly.

A correct fix (emit find_dependency(Boost) only when prevail was built against a
Boost target, or provide the headers target for the NuGet-header case) can't be
validated h... (continued)

9160 of 10590 relevant lines covered (86.5%)

6466793.21 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
75.0
 -25.0% src/spec/type_descriptors.hpp
Jobs
ID Job ID Ran Files Coverage
1 run-Release - 28930708353.1 78
85.6
 GitHub Action Run
2 run-Debug - 28930708353.2 76
84.77
 GitHub Action Run
Source Files on build 28930708353